a-mayb3/Kanban_clone_backend
1
1
Fork 0
mirror of https://github.com/a-mayb3/Kanban_clone_backend.git synced 2026-03-21 18:15:37 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed oversight where deleting a project would leave dangling tasks and user-to-project relations

Browse source
This commit is contained in:
Marta Borgia Leiva 2026-02-03 12:33:20 +01:00
parent e53fb3f773
commit 52f13f5023
1 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
routers/projects.py
View file

@ -205,6 +205,17 @@ def delete_project(project_id: int, db: db_dependency, request: Request):
user = get_user_from_jwt(request, db) user = get_user_from_jwt(request, db)
db_project = get_project_by_id_for_user(user, project_id, db) db_project = get_project_by_id_for_user(user, project_id, db)
## Remove dangling tasks and user associations
tasks: List[TaskBase] = db.query(TaskBase).filter(getattr(TaskBase, "project_id") == project_id).all()
for task in tasks:
db.delete(task)
db_project.tasks.remove(task)
users: List[ProjectUserBase] = db.query(ProjectUserBase).join(ProjectUserBase).filter(getattr(ProjectBase, "id") == project_id).all()
for proj_user in users:
db_project.users.remove(proj_user)
proj_user.projects.remove(db_project)
db.delete(db_project) db.delete(db_project)
db.commit() db.commit()
return {"detail": "Project deleted successfully"} return {"detail": "Project deleted successfully"}
@ -217,5 +228,7 @@ def delete_project_task(project_id: int, task_id: int, db: db_dependency, reques
db_task = get_task_by_id_for_project(db_project, task_id, db) db_task = get_task_by_id_for_project(db_project, task_id, db)
db.delete(db_task) db.delete(db_task)
db_project.tasks.remove(db_task)
db.commit() db.commit()
return {"detail": "Task deleted successfully"} return {"detail": "Task deleted successfully"}